commit 4309ceb7b165a42534514ca9933846cc0912bdae
author Nicolas Pena <npm@chromium.org> Thu Nov 15 20:00:44 2018
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Thu Nov 15 20:11:39 2018
tree 7cf54a8ded8051651cacbc679163d266e6a5108e
parent 794b7ee9292f09802cd41e41a04be420b1d7bec3

[LongTasks] Change TaskAttributionTiming name to 'unknown' At TPAC, we agreed that 'script' is confusing because it implies that longtasks only measure script work. Thus, we decided to change the name to 'unknown'. Also see https://github.com/w3c/longtasks/issues/47. Change-Id: I5a0666d0fa078bfeac8ab6e8397b9b51aca3e833 Reviewed-on: https://chromium-review.googlesource.com/c/1336367 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#608479} 

longtask-timing/longtask-attributes.html

diff --git a/longtask-timing/longtask-attributes.html b/longtask-timing/longtask-attributes.html index 6af90cd..b5d44b0 100644 --- a/longtask-timing/longtask-attributes.html +++ b/longtask-timing/longtask-attributes.html @@ -32,7 +32,7 @@  'Exactly one attribution entry is expected');  const attribution = longtask.attribution[0];  assert_equals(attribution.entryType, 'taskattribution'); - assert_equals(attribution.name, 'script'); + assert_equals(attribution.name, 'unknown');  assert_equals(attribution.duration, 0);  assert_equals(attribution.startTime, 0);  assert_equals(attribution.containerId, ''); @@ -52,4 +52,4 @@  }, 'Performance longtask entries are observable.');  </script>   -</body> \ No newline at end of file +</body> 

longtask-timing/longtask-in-childiframe-crossorigin.html

diff --git a/longtask-timing/longtask-in-childiframe-crossorigin.html b/longtask-timing/longtask-in-childiframe-crossorigin.html index 17b0fd2..aaabce5 100644 --- a/longtask-timing/longtask-in-childiframe-crossorigin.html +++ b/longtask-timing/longtask-in-childiframe-crossorigin.html @@ -33,7 +33,7 @@  'Exactly one attribution entry is expected');  const attribution = longtask.attribution[0];  assert_equals(attribution.entryType, 'taskattribution'); - assert_equals(attribution.name, 'script'); + assert_equals(attribution.name, 'unknown');  assert_equals(attribution.duration, 0);  assert_equals(attribution.startTime, 0);  assert_equals(attribution.containerId, 'child-iframe-id'); 

longtask-timing/longtask-in-childiframe.html

diff --git a/longtask-timing/longtask-in-childiframe.html b/longtask-timing/longtask-in-childiframe.html index b713704..34b802c 100644 --- a/longtask-timing/longtask-in-childiframe.html +++ b/longtask-timing/longtask-in-childiframe.html @@ -38,7 +38,7 @@  'Exactly one attribution entry is expected');  const attribution = longtask.attribution[0];  assert_equals(attribution.entryType, 'taskattribution'); - assert_equals(attribution.name, 'script'); + assert_equals(attribution.name, 'unknown');  assert_equals(attribution.duration, 0);  assert_equals(attribution.startTime, 0);  assert_equals(attribution.containerId, 'child-iframe-id'); 

longtask-timing/longtask-in-externalscript.html

diff --git a/longtask-timing/longtask-in-externalscript.html b/longtask-timing/longtask-in-externalscript.html index 51c58af..076f0f2 100644 --- a/longtask-timing/longtask-in-externalscript.html +++ b/longtask-timing/longtask-in-externalscript.html @@ -29,7 +29,7 @@  'Exactly one attribution entry is expected');  const attribution = longtask.attribution[0];  assert_equals(attribution.entryType, 'taskattribution'); - assert_equals(attribution.name, 'script'); + assert_equals(attribution.name, 'unknown');  assert_equals(attribution.duration, 0);  assert_equals(attribution.startTime, 0);  assert_equals(attribution.containerId, ''); @@ -47,4 +47,4 @@  }  }, 'Performance longtask entries are observable.');  </script> -</body> \ No newline at end of file +</body> 

longtask-timing/longtask-in-parentiframe.html

diff --git a/longtask-timing/longtask-in-parentiframe.html b/longtask-timing/longtask-in-parentiframe.html index 2e7a999..778edc1 100644 --- a/longtask-timing/longtask-in-parentiframe.html +++ b/longtask-timing/longtask-in-parentiframe.html @@ -15,7 +15,7 @@  window.addEventListener('message', t.step_func(e => {  assert_equals(e.data['entryType'], 'longtask');  assert_equals(e.data['frame-attribution'], 'same-origin-ancestor'); - assert_equals(e.data['task-attribution'], 'script'); + assert_equals(e.data['task-attribution'], 'unknown');  assert_equals(e.data['containerId'], '');  assert_equals(e.data['containerName'], '');  assert_equals(e.data['containerSrc'], ''); 

longtask-timing/longtask-in-raf.html

diff --git a/longtask-timing/longtask-in-raf.html b/longtask-timing/longtask-in-raf.html index 8a5a729..2d30ac3 100644 --- a/longtask-timing/longtask-in-raf.html +++ b/longtask-timing/longtask-in-raf.html @@ -29,7 +29,7 @@  'Exactly one attribution entry is expected');  const attribution = longtask.attribution[0];  assert_equals(attribution.entryType, 'taskattribution'); - assert_equals(attribution.name, 'script'); + assert_equals(attribution.name, 'unknown');  assert_equals(attribution.duration, 0);  assert_equals(attribution.startTime, 0);  assert_equals(attribution.containerId, ''); 

longtask-timing/longtask-in-sibling-iframe-crossorigin.html

diff --git a/longtask-timing/longtask-in-sibling-iframe-crossorigin.html b/longtask-timing/longtask-in-sibling-iframe-crossorigin.html index cfcc189..b73112e 100644 --- a/longtask-timing/longtask-in-sibling-iframe-crossorigin.html +++ b/longtask-timing/longtask-in-sibling-iframe-crossorigin.html @@ -15,7 +15,7 @@  window.addEventListener('message', t.step_func(e => {  assert_equals(e.data['entryType'], 'longtask');  assert_equals(e.data['frame-attribution'], 'cross-origin-unreachable'); - assert_equals(e.data['task-attribution'], 'script'); + assert_equals(e.data['task-attribution'], 'unknown');  assert_equals(e.data['containerId'], '');  assert_equals(e.data['containerName'], '');  assert_equals(e.data['containerSrc'], ''); 

longtask-timing/longtask-in-sibling-iframe.html

diff --git a/longtask-timing/longtask-in-sibling-iframe.html b/longtask-timing/longtask-in-sibling-iframe.html index e6041e4..b8a4270 100644 --- a/longtask-timing/longtask-in-sibling-iframe.html +++ b/longtask-timing/longtask-in-sibling-iframe.html @@ -15,7 +15,7 @@  window.addEventListener('message', t.step_func(e => {  assert_equals(e.data['entryType'], 'longtask');  assert_equals(e.data['frame-attribution'], 'same-origin'); - assert_equals(e.data['task-attribution'], 'script'); + assert_equals(e.data['task-attribution'], 'unknown');  assert_equals(e.data['containerId'], 'longtask-iframe-id');  assert_equals(e.data['containerName'], 'longtask-iframe-name');  assert_equals(e.data['containerSrc'], 'resources/subframe-with-longtask.html');